Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource .get method takes params directly #131

Closed
wants to merge 1 commit into from

Conversation

jcutrell
Copy link
Collaborator

@jcutrell jcutrell commented Jun 3, 2014

Having the :params => params was causing a 400 error, as it essentially was causing the .get to turn the params into something irrelevant to the REST API.

Having the :params => params was causing a 400 error, as it essentially was causing the .get to turn the params into something irrelevant to the REST API.
@adelevie
Copy link
Owner

adelevie commented Jun 3, 2014

You now have commit access. Use it wisely and thanks for your
contributions. Talk to @sbonami and @jamonholmgren.

On Tue, Jun 3, 2014 at 12:18 PM, Jonathan Cutrell notifications@github.com
wrote:

Having the :params => params was causing a 400 error, as it essentially
was causing the .get to turn the params into something irrelevant to the

REST API.

You can merge this Pull Request by running

git pull https://github.com/jcutrell/parse_resource patch-4

Or view, comment on, or merge it at:

#131
Commit Summary

  • Resource .get method takes params directly

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#131.

@jcutrell
Copy link
Collaborator Author

jcutrell commented Jun 3, 2014

Looking into what caused the build to fail.

@jamonholmgren
Copy link
Collaborator

👍 Make magic happen @jcutrell.

@jcutrell
Copy link
Collaborator Author

jcutrell commented Jun 4, 2014

Will do.

I ran into some issues yesterday that caused a good number of tests to break, so I’m gonna go through and clean out the errors and write some new tests. (In any case, this particular PR definitely doesn’t need to happen.)

I’ve got some ideas for new features that I can put in a milestone.

Thanks for the go-ahead!

On Jun 4, 2014, at 10:52 AM, Jamon Holmgren notifications@github.com wrote:

Make magic happen @jcutrell.


Reply to this email directly or view it on GitHub.

@jcutrell jcutrell closed this Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants