Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate when displaying modal in mobile mode #831

Merged
merged 4 commits into from
May 11, 2021
Merged

validate when displaying modal in mobile mode #831

merged 4 commits into from
May 11, 2021

Conversation

elsiosanchez
Copy link
Collaborator

@elsiosanchez elsiosanchez commented May 10, 2021

Bug report / Feature

validate when displaying modal in mobile mode

cal

@elsiosanchez elsiosanchez added 02 Bug Something isn't working 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day labels May 10, 2021
@oscarinak
Copy link
Collaborator

oscarinak commented May 10, 2021

The PR verification was carried out in the following service "https://deploy-preview-831--stoic-lamport-68decf.netlify.app/" where when being in mobile mode and consulting the change history of a field this shows another sale which appears on the right side and shows the history of that field and a button to close the window

Verificación_pullR_831

Verificación_ParteII_pullR-831

  • Observations:
    When a field that does not have a history is consulted, it does not show any description as detailed in PR # 830

@oscarinak
Copy link
Collaborator

Well, but you have an observation

@yamelsenih yamelsenih merged commit 03eb894 into adempiere:develop May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Bug Something isn't working 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants