Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get lookup item #887

Merged
merged 6 commits into from
May 31, 2021

Conversation

EdwinBetanc0urt
Copy link
Collaborator

@EdwinBetanc0urt EdwinBetanc0urt commented May 28, 2021

Bug report / Feature

Steps to reproduce

  1. Open the Product Organization process.

Screenshot or Gif

Before this PR:
https://user-images.githubusercontent.com/20288327/120051353-496e0200-bfee-11eb-867c-31fe640a3a8a.mp4

After this PR:
https://user-images.githubusercontent.com/20288327/120051427-9c47b980-bfee-11eb-89ae-476c08e0115e.mp4

Expected behavior

Lookup fields are expected to get the heats with the lookup item request if they have a default value.
And if they don't get values they should not give error.

Other relevant information

  • Your OS: Linux Mint 19.1 Cinnamon x64.
  • Browser: Mozilla Firefox 88.0.1.
  • Node.js version: 12.20.0.
  • adempiere-vue version: 4.3.1.

Additional context

Related to but not dependent on adempiere/gRPC-API#3
Related to but not dependent on adempiere/gRPC-API#3

@EdwinBetanc0urt EdwinBetanc0urt self-assigned this May 29, 2021
@EdwinBetanc0urt EdwinBetanc0urt added 02 Bug Something isn't working 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day (UILP) UI Lookups Lookups of Fields labels May 29, 2021
@oscarinak
Copy link
Collaborator

The PR verification was carried out in the service "https://deploy-preview-887--stoic-lamport-68decf.netlify.app/" where it complies with what is described in the PR

Verificación_PullR887

@oscarinak
Copy link
Collaborator

Good

@yamelsenih yamelsenih merged commit 3479b6f into adempiere:develop May 31, 2021
@EdwinBetanc0urt EdwinBetanc0urt deleted the bugfix/get-lookup-item branch June 1, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Bug Something isn't working 27 Fast Resolution Very fast Resolution for a issue, can be completed along the day (UILP) UI Lookups Lookups of Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants