Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in ProjectIssue #2163

Closed
SusanneCalderon opened this issue Dec 4, 2018 · 0 comments
Closed

Errors in ProjectIssue #2163

SusanneCalderon opened this issue Dec 4, 2018 · 0 comments

Comments

@SusanneCalderon
Copy link
Collaborator

2 errors generating a project Issue

  • Create a Project Issue based on a Expense Report
    When the project has no issues, the method projectIssueHasExpense always returns true, even if the issue list is empty.
    Solution: return false when the issue List is empty.
    Class ProjectIssue, line 263
{
		if (projectIssues == null)
			projectIssues = project.getIssues();
		**if (projectIssues.isEmpty())
			return false;**
		Boolean exists = projectIssues.stream().allMatch(projectIssue -> projectIssue.getS_TimeExpenseLine_ID() == timeExpenseLineId);
		if (exists)
				return true;
		return false;
}	//	projectIssueHasExpense
  • Class MProjectIssue, processIt, line 161
    The Transaction is generated with movementtype MOVEMENTTYPE_WorkOrderPLUS, value W+, which means, that the calculation in costmethod adds the amount. The correct Movementtype is MOVEMENTTYPE_WorkOrder, Value W-
@SusanneCalderon SusanneCalderon self-assigned this Dec 4, 2018
SusanneCalderon added a commit to SusanneCalderon/adempiereSusanne that referenced this issue Dec 4, 2018
e-Evolution added a commit that referenced this issue Dec 6, 2018
e-Evolution pushed a commit to e-Evolution/adempiere that referenced this issue Dec 7, 2018
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Dec 7, 2018
* develop: (31 commits)
  adempiere: adempiere#2095 StackOverFlow Error in WAcctViewer
  adempiere#2183 Add support for Tomcat 8.5 adempiere#2183
  adempiere#2183 Add support the Tomcat 8.5 and deployments adempiere#2183
  adempiere#2149 Update Oracle JDBC Driver for 18.3 JDBC driver (ojdbc8.jar) adempiere#2149
  adempiere#2079, Remove Duplicated XML for Dashboard Access, reference to issue: adempiere#2079
  adempiere#2069, Remove bad constraint for C_BPartner_Location on M_Movement, reference to issue: adempiere#2069
  adempiere#2161 Setup ADempiere 391 Release adempiere#2161
  adempiere#2161 Setup ADempiere 391 Release adempiere#2161
  adempiere#2149 Update Oracle JDBC Driver for 18.3 JDBC driver (ojdbc8.jar) adempiere#2149
  adempiere#2147 Remove incompatible statement for Oracle SQL for new functionality of Tree adempiere#2147
  adempiere#2146 Update PostgreSQL JDBC Driver for 42.2.5 Released adempiere#2146 - Released 27 August 2018
  adempiere#2145 Fix statements in Migration XML script for Oracle support adempiere#2145
  adempiere#2144 Remove migration steps with orphan records adempiere#2144
  adempiere#2171, Remove old form of menu, reference to issue: adempiere#2171
  adempiere#2169, Improve default feature for XML parser and builder, reference to issue: adempiere#2169
  adempiere#2167, Add enhancement for allows file types, reference to issue: adempiere#2167
  adempiere#2165, Add new approach for Copy role process, reference to issue: adempiere#2165
  adempiere: adempiere#2163 Errors in ProjectIssue
  adempiere#2159, Add validation for not null UUID, reference to issue: adempiere#2159
  adempiere#2159, Add created quantity, reference to issue:adempiere#2159
  ...

# Conflicts:
#	migration/390lts-391/04380_2095_KeyColumnsAsID.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants