New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spurious Error When Copying Roles #2165
Comments
Hi @marcalwestf i think that @adaxa-steven have a old code, i was changed it a long time before, see this issue: #264 Also here a diff of current ADempiere: I will to change it class for new approach |
…issue: adempiere#2165 (cherry picked from commit b0a6e9d)
* develop: (31 commits) adempiere: adempiere#2095 StackOverFlow Error in WAcctViewer adempiere#2183 Add support for Tomcat 8.5 adempiere#2183 adempiere#2183 Add support the Tomcat 8.5 and deployments adempiere#2183 adempiere#2149 Update Oracle JDBC Driver for 18.3 JDBC driver (ojdbc8.jar) adempiere#2149 adempiere#2079, Remove Duplicated XML for Dashboard Access, reference to issue: adempiere#2079 adempiere#2069, Remove bad constraint for C_BPartner_Location on M_Movement, reference to issue: adempiere#2069 adempiere#2161 Setup ADempiere 391 Release adempiere#2161 adempiere#2161 Setup ADempiere 391 Release adempiere#2161 adempiere#2149 Update Oracle JDBC Driver for 18.3 JDBC driver (ojdbc8.jar) adempiere#2149 adempiere#2147 Remove incompatible statement for Oracle SQL for new functionality of Tree adempiere#2147 adempiere#2146 Update PostgreSQL JDBC Driver for 42.2.5 Released adempiere#2146 - Released 27 August 2018 adempiere#2145 Fix statements in Migration XML script for Oracle support adempiere#2145 adempiere#2144 Remove migration steps with orphan records adempiere#2144 adempiere#2171, Remove old form of menu, reference to issue: adempiere#2171 adempiere#2169, Improve default feature for XML parser and builder, reference to issue: adempiere#2169 adempiere#2167, Add enhancement for allows file types, reference to issue: adempiere#2167 adempiere#2165, Add new approach for Copy role process, reference to issue: adempiere#2165 adempiere: adempiere#2163 Errors in ProjectIssue adempiere#2159, Add validation for not null UUID, reference to issue: adempiere#2159 adempiere#2159, Add created quantity, reference to issue:adempiere#2159 ... # Conflicts: # migration/390lts-391/04380_2095_KeyColumnsAsID.xml
I will add a change for it reported by @adaxa-steven: in this commit: to replace this bit of code that gets the file name from a path string: /** * Get name of file * @param fileName * @return */ private String getFileName(String fileName) { if(!Util.isEmpty(fileName)) { if(fileName.lastIndexOf("/") != -1) { fileName = fileName.substring(fileName.lastIndexOf("/") + 1); } } // Default return fileName; } for OS compatibility as "/" may not be the path separator Thanks |
#2165, change separator for support others OS, reference to issue:
Reported by Steven (@adaxa-steven ).
In the copy role process, copying from role a to role: role "A" and role "B" could get interchanged in the code because of the way the parameters are obtained.
Adaxa has provided Code to solve this problem; it will be tested (perhaps adapted) and integrated.
Here's how the change would look like:
The text was updated successfully, but these errors were encountered: