Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] New way to run ResultSet on MTree #3723

Closed
rcapecce opened this issue Feb 3, 2022 · 0 comments · Fixed by #3735
Closed

[Feature Request] New way to run ResultSet on MTree #3723

rcapecce opened this issue Feb 3, 2022 · 0 comments · Fixed by #3735
Assignees
@e-Evolution @yamelsenih

Comments

@rcapecce
Copy link
Collaborator

rcapecce commented Feb 3, 2022

Feature request

With the improvement of PR #3722, the use of the ResultSet in this class is changed due to the fact that the close is not being executed in a finally block, this can cause an error that the close of persistent objects is not executed correctly

Describe the solution you'd like

To make sure that persistent objects are closed correctly, the function DB.runResultSet(...) is used, which closes them transparently.

Additional context

As it is now, if any errors happen, these lingers will not be closed because they are not in a finally block

How to validate

This section si lauched when you open the Menu Window as System Administrator.

Aditional Information

Hi @e-Evolution, forcing an error to be thrown, I could see how the debug went to the finally block to close the objects, and the NPE that I forced, followed as an exception backwards in the stack.
@yamelsenih yamelsenih mentioned this issue Feb 3, 2022
Closed
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Feb 13, 2022
@e-Evolution
adempiere#3723 [Feature Request] New way to run ResultSet on MTree a…
a5fcfbc 
…dempiere#3723

- The implementation functional completely
@e-Evolution e-Evolution mentioned this issue Feb 13, 2022
Merged
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 23, 2022
@e-Evolution
adempiere#3723 [Feature Request] New way to run ResultSet on MTree ad…
4aebe25 
…empiere#3723

- The implementation functional completely
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 23, 2022
@e-Evolution
adempiere#3723 [Feature Request] New way to run ResultSet on MTree ad…
0c313fc 
…empiere#3723

- The implementation functional completely
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 23, 2022
@e-Evolution
adempiere#3723 [Feature Request] New way to run ResultSet on MTree ad…
5573f43 
…empiere#3723

- The implementation functional completely
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 23, 2022
@e-Evolution
Merge branch 'feature/MigrateLegacyCodeResultSetAndQuery' into featur…
cd305cc 
…e/3.9.4.RC.01

* feature/MigrateLegacyCodeResultSetAndQuery:
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  adempiere#3736 Missing entry of vavr-1.0.0-alpha-4.jar in .classpath adempiere#3736
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  - Define runResultSetFunction as public function
  New branch to refactor code to fix posible leak resource by legacy JDBC code and use the the new ADempiere Query API - Adding support to Intellij to run Test Suite

# Conflicts:
#	.idea/workspace.xml
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 23, 2022
@e-Evolution
Merge branch 'feature/MigrateLegacyCodeResultSetAndQuery' into featur…
c04a6c4 
…e/3.9.4.RC.01

* feature/MigrateLegacyCodeResultSetAndQuery:
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
e-Evolution added a commit to e-Evolution/adempiere that referenced this issue Mar 29, 2022
@e-Evolution
Merge branch 'develop' into feature/3715
84fa453 
* develop: (21 commits)
  adempiere adempiere#3777 FR: Copy C_Tax_ID for valid distribution Lines
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  adempiere#3768 [Feature Request] Adding the files in ZK to WebUI non fail adempiere#3768
  adempiere#3769 [Bug Report] The Distribution Line flag isInvertAccountSign not work adempiere#3769 - Fixed import
  adempiere#3769 [Bug Report] The Distribution Line flag isInvertAccountSign not work adempiere#3769
  adempiere#3737 [Feature Request] Add tax functionality to the requisition adempiere#3737 - Add XML Script
  adempiere#3765 [Feature Request] MDocumentStatus Implementing new approach to ResultSet adempiere#3765
  adempiere#3737 [Feature Request] Add tax functionality to the requisition adempiere#3737
  adempiere#3753 [Feature Request] Adding Support the Read Connection Using Tomcat, Wildfly , Jetty adempiere#3753
  adempiere#3742 [Feature Request] Add support the Import Order in Parallel and Change the approach to import adempiere#3742 - Validate if an Order was created in a previous execution
  adempiere#3742 [Feature Request] Add support the Import Order in Parallel and Change the approach to import adempiere#3742
  adempiere#3742 [Feature Request] Add support the Import Order in Parallel and Change the approach to import adempiere#3742
  adempiere#3736 Missing entry of vavr-1.0.0-alpha-4.jar in .classpath adempiere#3736
  adempiere#3723 [Feature Request] New way to run ResultSet on MTree adempiere#3723 - The implementation functional completely
  - Define runResultSetFunction as public function
  New branch to refactor code to fix posible leak resource by legacy JDBC code and use the the new ADempiere Query API - Adding support to Intellij to run Test Suite
  fix: Corrige error de numeracion
  feature: Incluye catalogo de ctas para Nicaragua
  ...

# Conflicts:
#	.idea/workspace.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e-Evolution e-Evolution

@yamelsenih yamelsenih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/migrate legacy code result set and query for MTree e-Evolution/adempiere
3 participants
@e-Evolution @yamelsenih @rcapecce