Rename all packages #3966
Rename all packages #3966
Conversation
|
@yamelsenih some questions Yamel:
Thanks! |
marcalwestf
added
the
17 Waiting for Information
|
... I see in the Github actions that there is a build with Gradle -BTW exited with an error- so I suppose, it is meant to run with Gradle... |
|
I started a terminal on Eclipse and went to the root of the project and run there My grade version is 6.3: I will update my grade version and try anew. |
Hi @marcalwestf Step by Step for build with gradleRequirements:
Export enviroment variable export ADEMIERE_LIBRARY_VERSION="some-version"Build with gradle cd /AdempiereRepo
gradle build |
Hi @marcalwestf this error was resolved yet |
|
Hi @marcalwestf the process "Process Production" is no longer supported because already exists the workflow for Production, this process was deprecated and instead just should run document action with process instead complete action |
Hi @marcalwestf these process are deprecated here: b032393 Please remove current XML and import it from source |
|
@yamelsenih Yamel, concerning the gradle error: Gradle build sucessAt last, I was able to get the exact result as the action when calling The reason: using different JDKs like zulu-jdk11.0.15, or java-11-openjdk-amd64 there were errors thrown. Correction of typoI notice, in all build.gradle files the variable name is This should be modified in all gradle.build files which refer to this variable to .gitignore for GradleAlso, the .gradle directory should be included in the .gitignore file, so it files are not considered to be pushed, which confuses otherwise: QuestionLast, but not least, I notice that |
|
@yamelsenih Yamel, I loaded and applied the XML file. The changes you made are OK and improve the usability. About the error at Production: the error is thrown when you click on the icon, as you can see in the following image. |
Hi @marcalwestf thanks, hahaha was me at 3:00 AM. This was resolved here: 305f560 |
Hi @marcalwestf this was resolved here: b2c8e0e The current functionality is unsupported for fields disabled or hidden |
|
hi @yamelsenih , at last, all the tests were positive. |
|
FYI:
|
|
@yamelsenih Yamel I found a potential problem, it is not correct to replace an MModel class with X_Model since the X_Model classes do not contain the business logic after and before saving and/or deleting. This may be that using the X_ class changes the behavior because it is not applying the business logic required in the MModel class. X_Model classes can be used for reading only but not for using the save method: Here is an example in the class with this problem: AbstractCostingMethod.java Please check any other refactory where you applied this procedure because it is not suitable.
I also realize that the code of the TestDocumentEngine.java class was removed from a test, the test does not pass and it is necessary to fix it later, do not remove the code, it is better to comment it and put a TODO: in the comment, we can ask Mike to review it for the behavior of the test since he was the one who designed that test. it's not good to sweep code under the rug :-) In the StandardCostingMethod.java class, code was removed although some utility classes were created, I could not find anywhere how that business logic that was executed before is now executed in this class. In special the variance cost standard
On the other hand, I see very well that all the callouts have been changed to a new package called controller, which seems correct to me, but since this is being done and the packages have been restructured, it seems very important to me to use the same pattern for all the callouts. that were moved from their current package, taking advantage of the fact that you already have the XML that changes the path of the package, it would be good if they all use the same pattern.
So the moment these changes are applied and my question is answered I can complete the merge. on the other hand, I want to thank you for your enormous effort in this great challenge it was not easy, but you did it, congratulations |
|
@yamelsenih, @e-Evolution about the gradle files: in the gradle documentation (https://docs.gradle.org/current/userguide/java_plugin.html#sec:java-extension) and other explanations (e.g. https://www.baeldung.com/gradle-sourcecompatiblity-vs-targetcompatibility), there is a welll-defined description of using sourceCompatibility and targetCompatibility. If we take into account that we compile ADempiere with JDK 11, but can execute with either JDK 11 or JDK 17, I think, the configuration should be This would allow us to compile up to JDK 11, and run with no less than JDK 17. |
…es in ADempiere's DSL
… standard cost method that was removed in previous commits
- Normalization of names for Callout of Assets, these were moved to the controller package - Normalization of process names and implementation using the abstract class - Move domino models to package org.adempiere.core.domains.models - Set the application dictionary items to the entity type for Fixed Assets - Fix the XML Script to define Release No and change the packages in the application dictionary
…the application dictionary
* develop: adempiere#3959 [Bug Report] Tomcat does not exist in the Read Connection Pool adempiere#3959 adempiere#3976 [Bug Report] Backward compatibility was broken for queryData web services adempiere#3976 Fix adempiere#3968 Fixing migration xml sequences Fix adempiere#3968 adempiere#3959 [Bug Report] Tomcat does not exist in the Read Connection Pool adempiere#3959 adempiere#3959 [Bug Report] Tomcat does not exist in the Read Connection Pool adempiere#3959 Fixing translations New Notification Window per user # Conflicts: # base/src/org/compiere/model/POInfo.java
There was a problem hiding this comment.
I finished the pending refactory in code and enhancements :
- Change package name from service to services to improve package names in ADempiere's DSL
- Add business functionality for the calculation of variations in the standard cost method that was removed in previous commits
- Change package name for Fixed Assets from FA to asset
- Normalization of names for Callout of Assets, these were moved to the controller package
- Normalization of process names and implementation using the abstract class
- Move domino models to package org.adempiere.core.domains.models
- Set the application dictionary items to the entity type for Fixed Assets
- Fix the XML Script to define Release No and change the packages in the application dictionary
Branch: feature/#Src-Change-Packages
Rename base Package
This pull request basically change the package name of all
I_andX_classes to new structure:Old structure:
New structure:
Here some checks:
Processes
Model Validators
Callouts
Forms
Step by Step for build with gradle
Requirements:
ADEMIERE_LIBRARY_VERSIONExport enviroment variable
Build with gradle
cd /AdempiereRepo gradle build