Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(patterns/structure): reorganise page structure #191

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

gael-boyenval
Copy link
Contributor

@gael-boyenval gael-boyenval commented Mar 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Dscription

Issue Number: #186

Refactor pages structure into sub directories. This is a first simple proposal, we will need to have a deep discussion around categorization.

Does this PR introduce a breaking change?

  • Yes
  • No

@gael-boyenval gael-boyenval added ✨ refactor A code change that neither fixes a bug nor adds a feature scope:component Anything related to a component status:await-core-team-review ⚡ design Anything related to design skills labels Mar 7, 2019
@CaptainJojo CaptainJojo temporarily deployed to staging March 7, 2019 16:00 Inactive
@melanieanglardLMFR
Copy link
Contributor

I don't know if there is an other issue to manage getting started section. We talked about transform tab section in sub-pages.

@CaptainJojo CaptainJojo temporarily deployed to staging March 11, 2019 08:32 Inactive
@gael-boyenval
Copy link
Contributor Author

gael-boyenval commented Mar 11, 2019

@melanieanglardLMFR : yes this is #157 , my next move !

@gael-boyenval gael-boyenval merged commit 33cfcfa into master Mar 11, 2019
@gael-boyenval gael-boyenval deleted the Refactor-menu-hierarchy branch March 11, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:component Anything related to a component ✨ refactor A code change that neither fixes a bug nor adds a feature ⚡ design Anything related to design skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants