Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unify icon's apis #428

Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix: Unify icon's apis #428

merged 3 commits into from
Jun 7, 2023

Conversation

MarinaRomanova
Copy link
Contributor

@MarinaRomanova MarinaRomanova commented Jun 1, 2023 •
edited by SimonMarquis
Loading

📋 Changes description

  • Unify icons APIs (use size as param in all cases, and not iconSize)
  • Refer to IconSize in ButtonDefaults
  • Delete no longer used Icon.kt

@SimonMarquis SimonMarquis marked this pull request as ready for review June 5, 2023 14:09
@SimonMarquis SimonMarquis enabled auto-merge (squash) June 7, 2023 15:56
@SimonMarquis SimonMarquis merged commit a065bc7 into main Jun 7, 2023
@SimonMarquis SimonMarquis deleted the icons branch June 7, 2023 15:56
@soulcramer soulcramer linked an issue Jun 9, 2023 that may be closed by this pull request
Don't use nested class for the icons #319
Closed
@soulcramer soulcramer mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonMarquis SimonMarquis SimonMarquis approved these changes

@soulcramer soulcramer soulcramer approved these changes

Assignees

@MarinaRomanova MarinaRomanova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't use nested class for the icons
3 participants
@MarinaRomanova @SimonMarquis @soulcramer