fix(modifiers): ensure modifier compatibility with the new modifier API

adfinis · Sep 13, 2022 · 54aaed0 · 54aaed0
1 parent cef9f5c
commit 54aaed0
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/addon/modifiers/register-uikit-events.js b/addon/modifiers/register-uikit-events.js
@@ -2,12 +2,11 @@ import { run } from "@ember/runloop";
 import { modifier } from "ember-modifier";
 import UIkit from "uikit";
 
-export default modifier(function registerUikitEvents(
-  element,
-  positional,
-  named
-) {
-  Object.entries(named).forEach(([name, fn]) => {
-    UIkit.util.on(element, name, (...args) => run(() => fn(...args)));
-  });
-});
+export default modifier(
+  (element, positional, named) => {
+    Object.entries(named).forEach(([name, fn]) => {
+      UIkit.util.on(element, name, (...args) => run(() => fn(...args)));
+    });
+  },
+  { eager: false }
+);
diff --git a/addon/modifiers/uk-tooltip.js b/addon/modifiers/uk-tooltip.js
@@ -1,8 +1,11 @@
 import { modifier } from "ember-modifier";
 import UIkit from "uikit";
 
-export default modifier(function ukTooltip(element, [title], options) {
-  const tooltip = UIkit.tooltip(element, { title, ...options });
+export default modifier(
+  (element, [title], options) => {
+    const tooltip = UIkit.tooltip(element, { title, ...options });
 
-  return () => tooltip.$destroy();
-});
+    return () => tooltip.$destroy();
+  },
+  { eager: false }
+);