-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to exclude certain parts from the build #13
Conversation
The treeshake pattern is very elegant. Documentation seems clear. Nice work! |
<td> | ||
A list of included components. Only components in this list will be | ||
included in your build. You should never use <code>whitelist</code> | ||
and <code>blacklist</code>! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you say that the two lists should not be used at the same time, i'd expect an error to be thrown in that case. I think right now the blacklist takes precedence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should definitely throw an error!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or at least a warning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the nitpick, LGTM!
This PR adds some options and fixes #12:
TODO
uk-icon
ifuseIcons: false