Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastboot #11

Closed
wants to merge 2 commits into from
Closed

Fastboot #11

wants to merge 2 commits into from

Conversation

jayvarner
Copy link
Contributor

Fixes #10

Copy link
Member

@anehx anehx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! FastBoot support is always a good idea!

@@ -24,7 +34,7 @@ module.exports = {

app.options.sassOptions.includePaths.push('node_modules');

app.import('node_modules/uikit/dist/js/uikit.min.js');
app.import('vendor/uikit.min.js');
app.import('node_modules/uikit/dist/js/uikit-icons.min.js');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you leave out the icons? I think if we support fastboot (which is definitely a good idea) we should support all of the features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left icons alone because it does not throw an error under fastboot. Considering #12, which seems like a good idea, it is probably best to continue handling them separately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still prefer adding it the same way for consistency since it doesn't hurt..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A solution for #12 is implemented in #13. Take a look if you want and tell me your opinion!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like what you did in #13 . Though that might cause a pretty significant rebase/refactor of this PR. Might be best to close this one so we can start fresh. :)

I hit a bit of a block on the testing last week. I haven't had a chance to dive back in. I got the ember-fastboot-addon-test set up on a no-dependency addon just fine. But I get errors with ember-uikit. Though I'm using my fork in a fastboot env without error. I can't remember all the errors. Each Node version (4, 6, and 7) all had different errors.

When I left it, I was starting to suspect something screwy with my local system. I should have some time at the end of the week to work it out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright so we'll close this one in favor of a new one. I'll try to free some time to check out fastboot compatibility as well!

Thanks for your review and your contribution to this addon!

@anehx
Copy link
Member

anehx commented Nov 30, 2017

BTW: Testing fastboot compatibility could be done with https://github.com/kaliber5/ember-fastboot-addon-tests

@anehx anehx mentioned this pull request Nov 30, 2017
@anehx anehx closed this Dec 6, 2017
@anehx anehx mentioned this pull request Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants