Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(infra-apps): update argocd to 4.0.* #604

Merged
merged 2 commits into from Mar 17, 2022
Merged

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented Mar 17, 2022

Description

Updates infra-apps to use argocd chart version 4.0.*

With the 4.0 release of the chart controller.enableStatefulSet is true per default to enable HA mode. If you want to keep using a deploymet you need to set it to false.
Also both the ApplicationSet and Notifications controller are now deployed as part of Argo CD, this will need additional resources in the cluster.
Please tune applicationSet.metrics and applicationSet.resources as well as notifications.metrics, notifications.resources, and (maybe) notifications.argocdUrl during this upgrade at the very least.

Issues

n/a

Changes

Chart changes

https://github.com/argoproj/argo-helm/tree/master/charts/argo-cd#400-and-above

The Argo CD Notifications and ApplicationSet are part of Argo CD now.

App changes

https://github.com/argoproj/argo-cd/blob/v2.3.0/docs/operator-manual/upgrading/2.2-2.3.md

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

Signed-off-by: Toni Tauro toni.tauro@adfinis.com

Signed-off-by: Toni Tauro <toni.tauro@adfinis.com>
@eyenx eyenx requested a review from a team as a code owner March 17, 2022 07:48
@eyenx eyenx requested review from inisitijitty and tongpu and removed request for a team March 17, 2022 07:48
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2022
@eyenx eyenx requested a review from hairmare March 17, 2022 07:50
@eyenx eyenx enabled auto-merge (squash) March 17, 2022 08:13
@eyenx eyenx merged commit 288d3d0 into master Mar 17, 2022
@eyenx eyenx deleted the chore/update-argocd-to-4.0 branch March 17, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants