fix: change the error message, and the tests

adfinis · Mar 30, 2023 · 6ca6185 · 6ca6185
1 parent 979e411
commit 6ca6185
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/app/validators/moment.js b/app/validators/moment.js
@@ -26,7 +26,7 @@ export default function validateMoment(options = { gt: null, lt: null }) {
     }
     let valid = !!newValue && newValue._isValid;
     if (!valid) {
-      return "false";
+      return "The given value is not a valid value";
     }
 
     if (options.gt) {
@@ -35,7 +35,7 @@ export default function validateMoment(options = { gt: null, lt: null }) {
         getDateTimeIfValid(get(content, options.gt)) ||
         moment();
       if (newValue <= gtVal) {
-        valid = "false";
+        valid = `The value is smaller than ${options.gt}`;
       }
     }
     if (options.lt) {
@@ -45,7 +45,7 @@ export default function validateMoment(options = { gt: null, lt: null }) {
         moment();
 
       if (newValue >= ltVal) {
-        valid = "false";
+        valid = `The valus is larger than ${options.lt}`;
       }
     }
     return valid;

diff --git a/tests/unit/validators/moment-test.js b/tests/unit/validators/moment-test.js
@@ -4,7 +4,10 @@ import validateMoment from "timed/validators/moment";
 
 module("Unit | Validator | moment", function () {
   test("works without value", function (assert) {
-    assert.strictEqual(validateMoment()("key", null, null, {}, {}), "false");
+    assert.strictEqual(
+      validateMoment()("key", null, null, {}, {}),
+      "The given value is not a valid value"
+    );
     assert.true(validateMoment()("key", moment(), null, {}, {}));
   });
 
@@ -27,7 +30,7 @@ module("Unit | Validator | moment", function () {
         {},
         { otherKey: moment().add(1, "second") }
       ),
-      "false"
+      "The value is smaller than otherKey"
     );
   });
 
@@ -50,7 +53,7 @@ module("Unit | Validator | moment", function () {
         {},
         { otherKey: moment().add(-1, "second") }
       ),
-      "false"
+      "The valus is larger than otherKey"
     );
   });