This repository has been archived by the owner on May 13, 2024. It is now read-only.
refactor(sy-modal): glimmerify #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
derrabauke
commented
Feb 14, 2023
•
derrabauke
commented
- refactoring of sy-modal component
- peripheral refactoring of welcome-modal and sy-modal-target components
- fix of bug: refresh of absences not working properly #808
derrabauke
force-pushed
the
refactor-actvities-sy-modal
branch
from
1f79d58
to
2602b5d
Compare
Includes also the welcome-modal and sy-modal-target components
derrabauke
force-pushed
the
refactor-actvities-sy-modal
branch
from
2602b5d
to
6a7078e
Compare
luytena
reviewed
Feb 15, 2023
When closing the absence modal dialog the overview data will refetch, since it's quite probable this has led to a data change. The overhead in case nothing changed is acceptable.
derrabauke
force-pushed
the
refactor-actvities-sy-modal
branch
from
fc6380e
to
44e061e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.