Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC Retry & Timeout Support #216

Open
adhdtech opened this issue Jul 19, 2022 · 0 comments
Open

RPC Retry & Timeout Support #216

adhdtech opened this issue Jul 19, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@adhdtech
Copy link
Owner

Add retry and timeout options to DRP_Endpoint.SendCmd. Now that DRP_CmdError is used as a standard error class, return codes can be evaluated to determine whether or not a retry should be attempted.

A retry can be initiated by any of these conditions:

  • Timeout expiring (execution of ServiceCmd starts timer)
  • Error Codes: 408, 500, 503, 504, 507

Error codes other than those listed should result in a normal response to the client. If the retry threshold is reached, the last error code will be returned to the caller.

Regarding errors kicked back locally:

  • An RPC call timeout should result in a 408.
  • An error sending the command to the endpoint (missing, etc) should result in a 500.

Decisions to make:

  • Should the timeout parameter be passed on to downstream calls?
  • Should the timeout parameter be added as a new attribute or as part of DRP_Cmd.params?
@adhdtech adhdtech added the enhancement New feature or request label Jul 19, 2022
@adhdtech adhdtech added this to the Protocol Maintenance milestone Jul 19, 2022
@adhdtech adhdtech self-assigned this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant