Skip to content

Commit

Permalink
Allow exceptions to escape CallController#execute
Browse files Browse the repository at this point in the history
The goal is to allow spec runs to invoke controllers and get an exception when it occurs.  The current behavior catches the exception and sends it through the exception handler, which often will silently swallow it, especially if the tests complete and the process exits before the exception is worked from the queue.

This commit still has two broken tests, so more discussion is necessary.
  • Loading branch information
bklang committed May 28, 2014
1 parent 977f0ef commit 71c8849
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/adhearsion/call_controller.rb
Expand Up @@ -123,6 +123,7 @@ def execute!(*options)
rescue SyntaxError, StandardError => e
Events.trigger :exception, [e, logger]
on_error e
raise
ensure
after_call
logger.debug "Finished executing controller #{self.inspect}"
Expand Down

0 comments on commit 71c8849

Please sign in to comment.