FIX: prevent actor crash on AMI action when asterisk unavailable #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When a call starts while asterisk is running and before the call
is answered or terminated asterisk becomes unavailable, further ami
actions related to that call will result in "Celluloid: Actor crashed!".
This is caused because `...Asterisk::AMIAction#send_actions()` raises
Celluloid::DeadActorError, that crashes the translator. Even if after
a while asterisk becomes available, there isn't any translator to
process AMI actions and events.
To fix this issue Celluloid::DeadActorError have to be caught
within `...Asterisk::AMIAction#execute()`.
Update CHANGELOG.md
|
Thanks for this considered contribution. I need to think this through a little; I have some pending thoughts about how we handle this more generally which I need to formalise. |
|
Sure, take your time ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a call starts while asterisk is running and before the call is answered or terminated asterisk becomes unavailable, further ami actions related to that call will result in
Celluloid: Actor crashed!error messages. This is caused because...Asterisk::AMIAction#send_actions()raisesCelluloid::DeadActorError, that crashes the translator. Even if after a while asterisk becomes available, there isn't any translator to process AMI actions and events.To fix this issue
Celluloid::DeadActorErrorhave to be caught within...Asterisk::AMIAction#execute().How to reproduce?
After asterisk becomes unavailable,
Adhearsion::Rayo::Initializerwill try to reconnect to asterisk, but in this state any attempt to execute an AMI action will crash the translator.