Bump Reel version to 0.6.x, fixing client disconnection bug #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, but I am curious as to what the issue you are hitting is. I have probably seen that in the past :) |
|
It's celluloid/reel#150. Spent hours trying to figure it out only to find it was fixed over 3 years ago! |
|
Same JRuby failures as usual. |
2 similar comments
bklang
approved these changes
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works (not that the Adhearsion code does much with it) and fixes a nasty issue that's been keeping me up at night! Virginia will need to be bumped accordingly but that's still pointing at Adhearsion 2.6 right now and I don't use it at all.