Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPEC] relax nio4r constraint for specs #638

Merged
merged 1 commit into from Jul 10, 2019
Merged

[SPEC] relax nio4r constraint for specs #638

merged 1 commit into from Jul 10, 2019

Conversation

sfgeorge
Copy link
Member

@sfgeorge sfgeorge commented Jul 9, 2019

relax nio4r constraint for specs

This just became possible since nio4r-2.4.0 was re-released to include a -java version.

This reverts commit c4b9e9a.

@sfgeorge sfgeorge mentioned this pull request Jul 9, 2019
Merged
@coveralls
Copy link

coveralls commented Jul 9, 2019 •
edited

Coverage Status

Coverage increased (+0.01%) to 98.247% when pulling 4f8e70a on sfgeorge:relax-nio4r-ci-constraint into 4906f79 on adhearsion:develop.

@sfgeorge sfgeorge requested a review from lpradovera July 10, 2019 17:16
@sfgeorge
Copy link
Member Author

@lpradovera @gfaza Can you review this for me?

@gfaza
Copy link
Contributor

gfaza commented Jul 10, 2019

👍

@sfgeorge
Copy link
Member Author

Thank you, gents!

@sfgeorge sfgeorge merged commit 185f2c0 into adhearsion:develop Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bklang bklang bklang approved these changes

@lpradovera lpradovera Awaiting requested review from lpradovera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sfgeorge @coveralls @gfaza @bklang