[Feature] Send recognition timeout to UniMRCP #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would first require a matching pull request against the Rayo specification. http://xmpp.org/extensions/xep-0327.html#def-component-input |
|
Could I get test coverage and a changelog entry prior to merging this? Squashing to a single commit would also be awesome :) |
|
Sorry for the delay; I will get the test and changelog entry in today. |
|
@benlangfeld this is ready for another look once we hear back from TravisCI |
|
So you've included tests for the model, but not for the component side. Could you add those too? |
Resolved conflicts: lib/punchblock/translator/asterisk/component/mrcp_recog_prompt.rb send recognition timeout setting as UniMRCP option allowing dynamic setting of Recognition-Timeout in the MRCP messaging with speech recognition server Resolved conflicts: lib/punchblock/translator/asterisk/component/mrcp_recog_prompt.rb add test for setting recognition-timeout header update changelog add spec for mrcp_recog_prompt and enforce Rayo protocol in the #validate method
| @@ -34,6 +34,7 @@ def validate | |||
|
|
|||
| raise OptionError, "An initial-timeout value must be -1 or a positive integer." if @initial_timeout < -1 | |||
| raise OptionError, "An inter-digit-timeout value must be -1 or a positive integer." if @inter_digit_timeout < -1 | |||
| raise OptionError, "A recognition-timeout value must be -1, 0, or a positive integer." if @recognition_timeout < -1 | |||
There was a problem hiding this comment.
added this validation to match the default in the Rayo spec
benlangfeld
added a commit
that referenced
this pull request
Sep 29, 2014
…eout_to_unimrcp [Feature] Send recognition timeout to UniMRCP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an application to specify recognition timeout settings on a per
#askbasis when using Asterisk's UniMRCP module for speech recognition.