Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Add Recognition-Timeout as an Input attribute #95

Merged
merged 4 commits into from
Sep 22, 2014
Merged

Add Recognition-Timeout as an Input attribute #95

merged 4 commits into from
Sep 22, 2014

Conversation

Jared-Prime
Copy link
Contributor

Update to Rayo protocol to add support for Recognition-Timeout MRCP header in support of Punchblock Pull Request 228 .

@@ -35,6 +35,12 @@
<uri>http://voxeolabs.com</uri>
</author>
<revision>
<version>0.4</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bump the version on submission to the XSF. There are other changes that need submitting and I'm overdue on a batch update.

@benlangfeld
Copy link
Member

It's also necessary to add this to the schema for a full specification.

@Jared-Prime
Copy link
Contributor Author

Changes made minus the "schema"; I don't understand what you mean by "add this to the schema".

@benlangfeld
Copy link
Member

@Jared-Prime
Copy link
Contributor Author

gotcha. thanks

<attribute name="recognition-timeout" type="core:timeoutType" use="optional" default="-1">
<annotation>
<documentation>
Indicates the time (in seconds) alloted to match speech input before triggering a Nomatch completion.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other places in the specification [such as the INPUT element, and the RECORD element) reference milliseconds for timeouts. I'd suggest we need to be consistent. Plus, milliseconds is probably more appropriate when dealing with small values of time such as these kinds of timeouts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only chose seconds rather than milliseconds since that's how MRCP describes the setting. If we feel strongly, it's OK by me to change this to milliseconds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The priority is for Rayo to be self-consistent rather than consistent with other specs.

@Jared-Prime
Copy link
Contributor Author

@benlangfeld @bklang changed to milliseconds as requested

@benlangfeld
Copy link
Member

Could you explain how this is different from the initial-timeout already specified?

@Jared-Prime
Copy link
Contributor Author

intitial-timeout states how long to wait for speech before timing out.
recognition-timeout states, after speech has begun, how many more seconds
of input to allow prior to determining a positive match.

@benlangfeld
Copy link
Member

Could that be clarified in the spec itself?

benlangfeld added a commit that referenced this pull request Sep 22, 2014
Add Recognition-Timeout as an Input attribute
@benlangfeld benlangfeld merged commit 7ce1a34 into rayo:feature/rayo Sep 22, 2014
@benlangfeld
Copy link
Member

Thanks @Jared-Prime. This will be included in the next version of the Rayo spec. I'll prepare and submit that to the XSF today.

@benlangfeld
Copy link
Member

Submitted to the XSF. Will post here when I receive confirmation of publication of Rayo v0.5

@benlangfeld
Copy link
Member

Published by the XSF: http://xmpp.org/extensions/xep-0327.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants