Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assoc array assertions #8

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

peter279k
Copy link
Collaborator

@peter279k peter279k commented Mar 23, 2019

Introduction

This is a...

  • New feature

@peter279k peter279k requested a review from adhocore March 23, 2019 10:56
@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #8 into master will increase coverage by 0.59%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     95.83%   96.42%   +0.59%     
- Complexity       10       12       +2     
============================================
  Files             1        1              
  Lines            24       28       +4     
============================================
+ Hits             23       27       +4     
  Misses            1        1
Impacted Files Coverage Δ Complexity Δ
src/Asserts.php 96.42% <100%> (+0.59%) 12 <2> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59349ee...19b5a7e. Read the comment docs.

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. assert message string missing :)
everything else looks good.

src/Asserts.php Outdated

public function assertIsAssocArray(array $array)
{
$this->assertTrue(\array_keys($array) !== \range(0, \count($array) - 1));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert msg missing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will add that.

@adhocore adhocore merged commit ad35e39 into adhocore:master Mar 25, 2019
@peter279k peter279k mentioned this pull request Mar 25, 2019
1 task
@peter279k peter279k deleted the issue_#7 branch March 25, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants