Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker 18.09.0-ce-tp6 #171

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

mikenz
Copy link

@mikenz mikenz commented Oct 29, 2018

Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package. Addresses #166

Use a newer version of docker to avoid 8GB file size bug in the current AWS linux package
@mikenz
Copy link
Author

mikenz commented Oct 29, 2018

Successfully used to build 72.0.3590.0

@eliranhe
Copy link

eliranhe commented Nov 4, 2018

awesome job @mikenz! can't wait :)

@mikenz
Copy link
Author

mikenz commented Dec 16, 2018

@adieuadieu Any chance you can merge this so the automated builds start working again?

Thanks

@skunkworker
Copy link
Collaborator

@mikenz shouldn't this be changed to v18.09.0

@mikenz
Copy link
Author

mikenz commented Dec 28, 2018

@skunkworker yes. If @adieuadieu is interested in restoring the automated builds I'll happily update the PR.

@paparga
Copy link

paparga commented Feb 6, 2019

Hi @mikenz I tried your branch but I couldn't build chromium. I used /scripts/ec2-build.sh. Could you share your build?

Thanks!

@kiran-redhat
Copy link

@adieuadieu , please can you have a look at this PR? @mikenz has done really amazing work.

@adieuadieu
Copy link
Owner

Hi @mikenz. I'm late to the party.

I'm a little worried about the maintainability of the hard-coded docker value here. (The irony—or is it hypocrisy—of that statement is not lost on me..)

Is the root issue here that the docker package contained in yum's repository is outdated, hence the manual install? Would this also be resolved by using a newer version of ubuntu on the EC2 instance?

@adieuadieu
Copy link
Owner

@mikenz I should also add, thank you for your efforts and raising this PR.

@skunkworker
Copy link
Collaborator

skunkworker commented Nov 22, 2019

So without some changes Chrome 75? ( I think it's 75) and above won't build on the older environment as it stands right now. Though I do have a fork that builds using amazonlinux:2.0.20191016.0-with-sources. @adieuadieu is that something that I should create a PR for?

@AgDude
Copy link

AgDude commented May 14, 2020

@skunkworker please do create a PR, even if it isn't merged, the rest of the community would benefit from it.

@skunkworker
Copy link
Collaborator

@AgDude I've created an PR #257

I know it works for sure with Chrome 75 but I haven't touched it in a couple months, I did update all of the dependencies though in order to get it build.

@skunkworker
Copy link
Collaborator

@AgDude I got chrome 81 built with a more up-to-date branch today. #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants