Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to amazonlinux:2.0.20200722.0-with-sources to build Chrome 85 #258

Merged
merged 14 commits into from
Oct 4, 2020

Conversation

skunkworker
Copy link
Collaborator

@skunkworker skunkworker commented May 20, 2020

Update AMI to amazonlinux:2.0.20200406.0
Changed the git clone to be a shallow clone on the $RELEASE tag, making the download much quicker.

I was able to successfully build chrome 83.0.4103.61 with this branch.

@teledyn
Copy link

teledyn commented Sep 4, 2020

Thanks for contributing this!

I do encounter two problems trying to just build the headless-chrome on an AWS Linux 2 EC2 instance using build/build.sh as per the readme:

  1. the gn executable in linux64/ is not found -- I attempted a workaround by inserting a line just before that installs the binary and gn.py from https://github.com/zengcan/gn-bin and it appears to carry one until ...
  2. the compile of ../../headless/public/util/fontconfig.cc because the CHECK macros are not defined

Any guesses why these two would be missing?

@skunkworker
Copy link
Collaborator Author

Thanks for contributing this!

I do encounter two problems trying to just build the headless-chrome on an AWS Linux 2 EC2 instance using build/build.sh as per the readme:

  1. the gn executable in linux64/ is not found -- I attempted a workaround by inserting a line just before that installs the binary and gn.py from https://github.com/zengcan/gn-bin and it appears to carry one until ...
  2. the compile of ../../headless/public/util/fontconfig.cc because the CHECK macros are not defined

Any guesses why these two would be missing?

Hi @teledyn, I have a branch I'm working on that fixes those two issues and compiles successfully. At the moment I'm running into issues with chromedriver, but the only thing I did different to get it to compile was update the amazon linux ami docker image. See my most recent commit on this branch.

Once I get the chromedriver new session bug fixed I'll post my findings here.

@skunkworker
Copy link
Collaborator Author

As an update, this branch works and compiles correctly.
For some reason using the --single-process flag will cause chromedriver + chrome to hang on trying to get a new session. Otherwise this works as expected on Chrome 85 with no issues so far.

@skunkworker skunkworker changed the title Update to amazonlinux:2.0.20200406.0 to build Chrome 81 Update to amazonlinux:2.0.20200722.0-with-sources to build Chrome 85 Sep 17, 2020
Copy link
Owner

@adieuadieu adieuadieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @skunkworker — Thank you for your effort!

@kennedy
Copy link

kennedy commented Sep 25, 2020

can we have this merged?

@adieuadieu adieuadieu merged commit 0bb8c77 into adieuadieu:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants