Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epoch to letters and children #23

Merged
merged 3 commits into from
Mar 23, 2016

Conversation

adinapoli
Copy link
Owner

cc @srijs

As I'm on Easter holidays over here, I spent 2 hours of hacking time doing 2 things:

  1. Adding the concept of "epochs" as you suggested, so that we can ignore stale DeadLetters. I have also cleaned up the restartChild section, got rid of the yielded Bool in favour of a more richer data structure RestartResult and finally moved emitting the events down to handleEvents, it seems just much cleaner.
  2. I fixed a bug in handleEvent where my typeOf check was never firing. The subtleties was that what we had as input of typeOf was SomeException thus that check was always yielding False regardless which kind of Exception we had as input. Yikes!

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.07%) to 85.621% when pulling 048c5bc on add-epoch-to-letters-and-children into da93c5f on master.

@adinapoli adinapoli merged commit ec44b0b into master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants