Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @srijs
As I'm on Easter holidays over here, I spent 2 hours of hacking time doing 2 things:
DeadLetter
s. I have also cleaned up therestartChild
section, got rid of the yieldedBool
in favour of a more richer data structureRestartResult
and finally moved emitting the events down tohandleEvents
, it seems just much cleaner.handleEvent
where mytypeOf
check was never firing. The subtleties was that what we had as input oftypeOf
wasSomeException
thus that check was always yieldingFalse
regardless which kind ofException
we had as input. Yikes!