Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added provider emote id in returned emote json #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matyjb
Copy link

@matyjb matyjb commented Sep 14, 2023

Issue:
Creating unique key or filename for each of the emote (for emotes like "Harambe" it's ok, but what for ":)" where ":" character is invalid for a filename)

Possible solution:
Parsing the unique key from the URL of the emote. However, it's time-consuming and what if the URL changes?

Simple solution:
I propose in this pull request just passing emotes ID returned by twitch/7tv/bttv/ffz to the Emote object, so it can be returned by tEmotes API. This way, unique keys (or file names) for each emotes can be easily created by combining its ID and the provider's name (for example: 60ae7316f7c927fad14e6ca2_7tv.webp)

I hope this will be accepted as these IDs can come in handy for anyone using the tEmotes API :)

@adiq
Copy link
Owner

adiq commented Dec 20, 2023

@matyjb thank you for contributing!
I'll consider introducing such change in the coming days and hopefully we could get it merged soon 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants