-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address 2.0 #115
Comments
Now that we allow multiple addresses do we need to include 'type'? |
Probably. Enum? |
Sure ...
Any to add/subtract? |
Think we should build a codelist 'addressType' to use in mdEditor? |
No enum. An array of strings, like phone->service. |
Got a problem with 'addressType'. Our address block parallels ISO organization which includes email addresses. Email addresses may be the only addresses in the block - no mailing or physical address. Doesn't seem quite right to add another type 'email'. Either we assume some default for 'addressType' - mailing would be my vote - or we move electronicMailAddresses into its own element parallel to address. |
Well, I always thought it was weird having e-mail in the same object. Especially with it being increasingly common these days to have entities without an address. We could just wrap all the "address" properties into another, e.g. "location". Could make it an array too so you can associate multiple address with your e-mail at once. That way we can have e-mail without a location(address). |
So, which are you thinking? ... {
"address": [
{
"addressType": [""],
"deliveryPoint": [""],
"city": "",
"administrativeArea": "",
"postalCode": "",
"country": ""
}
],
"electronicMailAddress": [""],
"location": [
{
"address": [
{
"addressType": [""],
"deliveryPoint": [""],
"city": "",
"administrativeArea": "",
"postalCode": "",
"country": ""
}
],
"electronicMailAddress": [""]
}
]
} How much advantage is there to having multiple email blocks? I can't see much advantage unless we expand the address block again and make address more like a true location by adding a 'locationName' in additon to 'addressType'. This would associate email addresses with a location not an address. Otherwise just more work to collect all the email addresses and decide which to use. See below ... {
"location": [
{
"locationName": "",
"address": [
{
"addressType": [""],
"deliveryPoint": [""],
"city": "",
"administrativeArea": "",
"postalCode": "",
"country": ""
}
],
"electronicMailAddress": [""]
}
]
} Is this getting out of control? |
I was actually thinking: {
"address": [{
"location": [{
"addressType": [""],
"deliveryPoint": [""],
"city": "",
"administrativeArea": "",
"postalCode": "",
"country": ""
}],
"electronicMailAddress": [""]
}]
} Just adding the |
In that case I would argue (politely) that 'location' creates multiple addresses for multiple address blocks without distinction to why there are is any difference. Might as well just go with elevating the 'electronicMailAddress' element to the level of 'address[]' - first example. |
After further discussions (on the phone) we decided elevate 'electronicMailAddress' to the base of 'contact'. Although it is shown in the model above it is no longer officially part of 'address'. See 'contact 2.0' issue #48. |
"address".
Changes:
see ISO XML example responsibleParty -3.xml
The text was updated successfully, but these errors were encountered: