Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Acquisitions (v2.10.0) #322

Draft
wants to merge 62 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Apr 29, 2024

Waiting on #335 and a develop->master PR to release v2.9.5

Closes #254

Closes #213
Closes #214
Closes #215
Closes #216
Closes #217
Closes #218
Closes #219
Closes #220
Closes #221
Closes #222
Closes #250
Closes #251
Closes #252
Closes #319

Changes

Version 2.10.0-beta.1

Testing

https://acq.jwaspin.dev/

Readme

Fixed the README to reference the correct name of the schema gem

New Feature: Acquisitions

The Acquisitions class along with all the associated classes. Includes example file and schema definition file.

Added Acquisitions array to metadata object definition.

New Classes

  • Acquisition
  • Platform
  • Instrument
  • InstrumentationEventList
  • InstrumentationEvent
  • Plan
  • Operation
  • Objective
  • Environment
  • Event
  • Pass
  • Requirement
  • RequestedDate

jwaspin and others added 30 commits February 12, 2024 10:14
* Fix Typo

DQ_CompletenessOmmission to DQ_CompletenessOmission

* Increment Patch Version

* 2.8.3

* Add DQ_NonQuantitativeAttributeAccuracy
commit f02a08c
Author: Johnathan <jwaspin@users.noreply.github.com>
Date:   Tue Feb 13 15:17:33 2024 -0700

    Release Version 2.9.0 (#289)

    * Upgrade mdCodes

    mdCodes -> 2.9.0

    * Increment Ruby Version

    v2.8.4

    * Increment package.json Version

    v2.8.4
    Update package-lock.json

    * Increment Patch Version

    v2.8.4

    * Update package-lock.json

    * Replace bower.json

    * Re-remove bower.json

    * Increment Minor Version

commit 5b598a0
Author: Johnathan <jwaspin@users.noreply.github.com>
Date:   Mon Feb 12 11:32:34 2024 -0700

    Fix DQ_CompletenessOmission Typo (#284)

    * Fix Typo

    DQ_CompletenessOmmission to DQ_CompletenessOmission

    * Increment Patch Version

    * 2.8.3

    * Add DQ_NonQuantitativeAttributeAccuracy
Add acquisitions to metadata.
* Add instrumentationEventList.json schema and example file

* Add instrumentationEvent.json schema and example file (#298)

* Add instrumentationEvent.json schema and example file

* add reference to revision class. add enum to eventype

* fix eventType in example

* Add revision.json schema definition with example (#300)

* Add revision.json schema definition with example

* Add array type for dateInfo in revision.json

* Add reference to date
* Add acq-instrument.json schema and example file

* Update  history to instrumentationEventList.json
* Add requestedDate.json schema and example

* Update description in requestedDate.json schema

* Refactor requestedDate schema to use common date definition
* Add acq-event.json schema and example file

* Add description to class

* Update "time" field in acq-event schema to use common date definition
* Add acq-pass.json schema and example file

* Add required

* Change reference to string
* Add acq-platform.json schema and example file

* Update id in platform schema

* Update platform history schema reference

* add hostId to schema

* Remove hostId

My mistake, I was looking at the wrong class.

---------

Co-authored-by: Johnathan Aspinwall <jwaspin@gmail.com>
* Add acq-objective.json schema and example file

* Update objectiveType to have enum values

* add objectiveType example

* change strings to references of classes
* Add acq-requirement class with example

* Add descriptions

* rename to acq-RequestedDate

* Fix acq-requirement example

* Add required fields to acq-requirement
* Fix examples to include array for clarity.

* Fix acq-operation example

* fix instrumentationEvent example
* rename id's and and refs to remove `acq-` prefix

* remove acq- prefix from filenames

* Update description to better reflect id's purpose
@jwaspin jwaspin marked this pull request as ready for review April 29, 2024 22:26
@jwaspin jwaspin marked this pull request as draft May 7, 2024 19:44
jwaspin and others added 18 commits May 7, 2024 13:46
And update mdCodes to official release of 2.9.3
mdCodes updated to 2.9.4-beta.4
mdJson-schemas updated to 2.9.3-beta.2
#331)

* fix citations within instrumentationEvent and instrumentationEventList. remove required parentOperation in operation class.

* chore: Update version to 2.10.0-beta.1

---------

Co-authored-by: Johnathan Aspinwall <jwaspin@gmail.com>
* chore: Update adiwg-mdjson_schemas and related files to version 2.10.0-beta.0

* chore: Update build script to include bundling step
@jwaspin jwaspin changed the title Feature: Acquisitions Feature: Acquisitions (v2.10.0) May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants