adLDAPUsers::find() enhancement, multiple search parameters

[ghost]

No description provided.

[Rich2k]

This should probably be backwards compatible by sending the original function to a new function that allowed multiple parameters

[ChadSikorra]

Shouldn't this be calling ldapSlashes against the search values in the array?

https://github.com/adldap/adLDAP/blob/master/lib/adLDAP/classes/adLDAPUtils.php#L103

[ghost]

Not exactly sure what you mean. Should I separate the functions
completely? I'm missing the "sending the original function to a new
function" portion of that comment.

Cesar Vega
775-445-3333

On Fri, Jan 31, 2014 at 1:01 AM, Richard Hyland notifications@github.comwrote:

This should probably be backwards compatible by sending the original
function to a new function that allowed multiple parameters

Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-33770451
.

[ghost]

Nice catch

Cesar Vega
775-445-3333

On Fri, Jan 31, 2014 at 4:25 PM, Chad Sikorra notifications@github.comwrote:

Shouldn't this be calling ldapSlashes against the search values in the
array?

https://github.com/adldap/adLDAP/blob/master/lib/adLDAP/classes/adLDAPUtils.php#L103

Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-33856356
.

[igittigitt]

I also strongly recommend in extending the find()-function to use single and multiple arguments. This may simply be done by checking if $searchField is an array. If so, $searchFilter should be an array also, where field/filter fields are mapped by index of array-entry.

I also whish to specify the resulting attributes. This is currently fixed inside find() by the line
$fields = array("samaccountname","displayname");