Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adLDAPUsers::find() enhancement, multiple search parameters #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adLDAPUsers::find() enhancement, multiple search parameters #17

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2014

No description provided.

@Rich2k
Copy link
Member

Rich2k commented Jan 31, 2014

This should probably be backwards compatible by sending the original function to a new function that allowed multiple parameters

@ChadSikorra
Copy link
Contributor

Shouldn't this be calling ldapSlashes against the search values in the array?

https://github.com/adldap/adLDAP/blob/master/lib/adLDAP/classes/adLDAPUtils.php#L103

@ghost
Copy link
Author

ghost commented Feb 4, 2014

Not exactly sure what you mean. Should I separate the functions
completely? I'm missing the "sending the original function to a new
function" portion of that comment.

Cesar Vega
775-445-3333

On Fri, Jan 31, 2014 at 1:01 AM, Richard Hyland notifications@github.comwrote:

This should probably be backwards compatible by sending the original
function to a new function that allowed multiple parameters

Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-33770451
.

@ghost
Copy link
Author

ghost commented Feb 4, 2014

Nice catch

Cesar Vega
775-445-3333

On Fri, Jan 31, 2014 at 4:25 PM, Chad Sikorra notifications@github.comwrote:

Shouldn't this be calling ldapSlashes against the search values in the
array?

https://github.com/adldap/adLDAP/blob/master/lib/adLDAP/classes/adLDAPUtils.php#L103

Reply to this email directly or view it on GitHubhttps://github.com//pull/17#issuecomment-33856356
.

@igittigitt
Copy link

I also strongly recommend in extending the find()-function to use single and multiple arguments. This may simply be done by checking if $searchField is an array. If so, $searchFilter should be an array also, where field/filter fields are mapped by index of array-entry.

I also whish to specify the resulting attributes. This is currently fixed inside find() by the line
$fields = array("samaccountname","displayname");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants