-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Golint 2 #33
Golint 2 #33
Conversation
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
+ Coverage 71.84% 71.93% +0.09%
==========================================
Files 19 19
Lines 760 759 -1
==========================================
Hits 546 546
+ Misses 180 179 -1
Partials 34 34
Continue to review full report at Codecov.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appreciated. There are a few API breaking changes in here (mostly due to not following conventions in naming of Url, etc). I found minimal impact to other code of mine that depends on this package, so I'm going to go ahead and merge.
@adlio You are right, I'm sorry I forgot to highlight the changed attribute names. Thanks for taking time to review and merge this! |
This PR replaces #32.
This PR makes the repo pass
golint
and adds linting to the Travis config.Comments have been added or their style fixed. A few variables have been renamed.