Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golint 2 #33

Merged
merged 48 commits into from
Feb 23, 2019
Merged

Golint 2 #33

merged 48 commits into from
Feb 23, 2019

Conversation

jtsaito
Copy link
Contributor

@jtsaito jtsaito commented Feb 20, 2019

This PR replaces #32.

This PR makes the repo pass golint and adds linting to the Travis config.

Comments have been added or their style fixed. A few variables have been renamed.

@jtsaito jtsaito mentioned this pull request Feb 20, 2019
@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #33 into master will increase coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   71.84%   71.93%   +0.09%     
==========================================
  Files          19       19              
  Lines         760      759       -1     
==========================================
  Hits          546      546              
+ Misses        180      179       -1     
  Partials       34       34
Impacted Files Coverage Δ
search.go 100% <ø> (ø) ⬆️
list-duration.go 83.33% <ø> (ø) ⬆️
arguments.go 100% <ø> (ø) ⬆️
label.go 100% <ø> (ø) ⬆️
webhook.go 41.46% <ø> (ø) ⬆️
list.go 100% <ø> (ø) ⬆️
member.go 100% <ø> (ø) ⬆️
list-duration-sort.go 100% <ø> (ø) ⬆️
token.go 100% <ø> (ø) ⬆️
action.go 94.91% <ø> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d090822...62480ab. Read the comment docs.

@jtsaito
Copy link
Contributor Author

jtsaito commented Feb 20, 2019

golint is no longer go-gettable for old go versions (1.7, 1.8). I added a workaround that ignores linting for these versions but lints for other versions of go.

Copy link
Owner

@adlio adlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated. There are a few API breaking changes in here (mostly due to not following conventions in naming of Url, etc). I found minimal impact to other code of mine that depends on this package, so I'm going to go ahead and merge.

@adlio adlio merged commit b0faddb into adlio:master Feb 23, 2019
@jtsaito
Copy link
Contributor Author

jtsaito commented Feb 24, 2019

@adlio You are right, I'm sorry I forgot to highlight the changed attribute names. Thanks for taking time to review and merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants