Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "total-clean" in tests/geolocation/GNUMakefile and tests/agemat/GNUMakefile #122

Closed
yukio-takeuchi opened this issue Feb 26, 2020 · 3 comments
Milestone

Comments

@yukio-takeuchi
Copy link

On Ubuntu 18.04
make g++-all
command failed when

make --directory=geolocation total-clean

is called from command $(MAKE) --directory=src CC=gcc CXX=g++ copy which is third command of make g++-all with following error message

make[4]: Entering directory '/home/yukiot/repository/admb/build/admb/tests/geolocation'
make[4]: *** No rule to make target 'total-clean'.  Stop.

In fact tests/geolocation/GNUMakefile lacks total-clean. tests/agemat/GNUMakefile also lacks total-clean.

They caused failure to build.
Probably this error should occur with other C++ compilers on Linux and Mac as well.

@johnoel
Copy link
Contributor

johnoel commented Feb 26, 2020

Also needed bc2eb9a

@johnoel
Copy link
Contributor

johnoel commented Feb 26, 2020

The total-clean target in tests directory is used mainly to remove downloaded git repositories such as glmmadmb and geolocation. The make --directory=tests total-clean target should be run BEFORE the top level make all target is called. If not, all downloaded files will be copied to the build/admb directory.

@johnoel johnoel closed this as completed Feb 26, 2020
@johnoel
Copy link
Contributor

johnoel commented Feb 26, 2020

Add e649a1c

@johnoel johnoel reopened this Feb 26, 2020
@johnoel johnoel closed this as completed Feb 26, 2020
@johnoel johnoel added this to the ADMB-12.2 milestone Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants