New element #27
Merged
New element #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In other Webdriver implementations, it is possible to call methods such as click on returned elements. This is now possible with the element object. Old methods that work on the browser object still work.
So you can choose between :
browser.element(locatorBy, locator, function (err, el) {
el.click(function() { ... });
}
And :
browser.element(locatorBy, locator, function (err, el) {
browser.clickElement(el, function() { ... });
}
This is implemented for :
- sendKeys
- click
- text
- textPresent
- getAttribute
- getValue
- clear
This sounds weird, one should ot have to update the unit test so that new code works. This goes against the principle of regression testing. However, for some reason equality test fail on objects even thought they share all properties and that all properties are strictly equal. There must be a better way to go about this.
|
This is great, any chance we can get this for the methods that return multiple elements? Right now all I get back is an object with a |
|
Could you open separate issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In other Webdriver implementations, it is possible to call methods such as click on returned elements. This is now possible with the element object. Old methods that work on the browser object still work.
So you can choose between :
And :
This is implemented for :
Problem
I had to rewrite two test cases for the tests to pass with the new element object.
Equality tests fail between two elements that have same properties and strict equality for all these properties.