-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the naming scheme of RDF and SHACL #264
Conversation
Prior, the naming scheme of the RDF and SHACL schemata were inconsistent to the JSON and XML schemat in their naming of abbreviations. This fixes it by applying the same naming rules on the RDF and SHACL schemata. Furthermore we update the examples. This fixes #263
@sebbader-sap I'll have a look this Friday. |
We update the development requirements to and re-record the test data for [aas-core-meta 8f18a8c]. In addition, we change the comment in the RDF schema to address the [comment raised in admin-shell-io/aas-specs pull request #264] as this change is in the same semantic "batch". See also: admin-shell-io/aas-specs#264 [aas-core-meta 8f18a8c]: aas-core-works/aas-core-meta@8f18a8c [comment raised in admin-shell-io/aas-specs pull request #264]: admin-shell-io/aas-specs#264 (comment)
We update the development requirements to and re-record the test data for [aas-core-meta 8f18a8c]. In addition, we change the comment in the RDF schema to address the [comment raised in admin-shell-io/aas-specs pull request #264] as this change is in the same semantic "batch". See also: admin-shell-io/aas-specs#264 [aas-core-meta 8f18a8c]: aas-core-works/aas-core-meta@8f18a8c [comment raised in admin-shell-io/aas-specs pull request #264]: admin-shell-io/aas-specs#264 (comment)
@sebbader-sap please double-check my answers & open the conversations again if necessary. @s-heppner the schemas and the test data have been regenerated in aas-core-codegen and testgen repositories so you can update this pull request. |
I updated the schemata from aas-core, using To my understanding, this should make this PR ready to be merged. |
@s-heppner both this PR and #268 look good to me - but before merging let's quickly agree on the release steps right after. We should immediately go for a |
Imo, we should also definitely include #269 in the release, since that fixes a major bug in the XSD. Other than that, I don't have a strong opinion on release numbering (though 3.0.7 seems sensible). Is there anyone else we should clarify our further action with? |
Previously, the naming scheme of the RDF and SHACL schemas were
inconsistent with the JSON and XML schemas in their naming of
abbreviations.
This patch fixes the naming by applying the same rules on the RDF
and SHACL schemas. Furthermore we update the examples.
This fixes #263.