Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the naming scheme of RDF and SHACL #264

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

s-heppner
Copy link
Collaborator

@s-heppner s-heppner commented Apr 19, 2023

Previously, the naming scheme of the RDF and SHACL schemas were
inconsistent with the JSON and XML schemas in their naming of
abbreviations.

This patch fixes the naming by applying the same rules on the RDF
and SHACL schemas. Furthermore we update the examples.

This fixes #263.

Prior, the naming scheme of the RDF and
SHACL schemata were inconsistent to the
JSON and XML schemat in their naming
of abbreviations.

This fixes it by applying the same
naming rules on the RDF and SHACL
schemata.
Furthermore we update the examples.

This fixes #263
@mristin
Copy link
Collaborator

mristin commented Apr 19, 2023

@sebbader-sap I'll have a look this Friday.

mristin added a commit to aas-core-works/aas-core-codegen that referenced this pull request Apr 19, 2023
We update the development requirements to and re-record the test data
for [aas-core-meta 8f18a8c].

In addition, we change the comment in the RDF schema to address the
[comment raised in admin-shell-io/aas-specs pull request #264] as this
change is in the same semantic "batch".

See also: admin-shell-io/aas-specs#264

[aas-core-meta 8f18a8c]: aas-core-works/aas-core-meta@8f18a8c
[comment raised in admin-shell-io/aas-specs pull request #264]: admin-shell-io/aas-specs#264 (comment)
mristin added a commit to aas-core-works/aas-core-codegen that referenced this pull request Apr 19, 2023
We update the development requirements to and re-record the test data
for [aas-core-meta 8f18a8c].

In addition, we change the comment in the RDF schema to address the
[comment raised in admin-shell-io/aas-specs pull request #264] as this
change is in the same semantic "batch".

See also: admin-shell-io/aas-specs#264

[aas-core-meta 8f18a8c]: aas-core-works/aas-core-meta@8f18a8c
[comment raised in admin-shell-io/aas-specs pull request #264]: admin-shell-io/aas-specs#264 (comment)
@mristin
Copy link
Collaborator

mristin commented Apr 19, 2023

@sebbader-sap please double-check my answers & open the conversations again if necessary.

@s-heppner the schemas and the test data have been regenerated in aas-core-codegen and testgen repositories so you can update this pull request.

@s-heppner
Copy link
Collaborator Author

I updated the schemata from aas-core, using

To my understanding, this should make this PR ready to be merged.

@sebbader-sap
Copy link
Contributor

@s-heppner both this PR and #268 look good to me - but before merging let's quickly agree on the release steps right after. We should immediately go for a V3.0.7 release, right? If so, we need to prepare an update of the release section in the README including the new release links.

@s-heppner
Copy link
Collaborator Author

Imo, we should also definitely include #269 in the release, since that fixes a major bug in the XSD.

Other than that, I don't have a strong opinion on release numbering (though 3.0.7 seems sensible). Is there anyone else we should clarify our further action with?

@sebbader-sap sebbader-sap changed the base branch from master to release/3.0.7 April 26, 2023 12:00
@sebbader-sap sebbader-sap merged commit 70671b3 into release/3.0.7 Apr 26, 2023
@sebbader-sap sebbader-sap deleted the Update_RDF_SHACL_Naming_Scheme branch April 26, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent naming of DataSpecificationIec61360
3 participants