Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of DataSpecificationIec61360 #263

Closed
arnoweiss opened this issue Apr 12, 2023 · 4 comments · Fixed by #264
Closed

Inconsistent naming of DataSpecificationIec61360 #263

arnoweiss opened this issue Apr 12, 2023 · 4 comments · Fixed by #264

Comments

@arnoweiss
Copy link

Currently, the V3-schemas for JSON and XML use the spelling DataSpecificationIec61360. However, the schemas in RDF and SHACL use the spelling DataSpecificationIEC61360. This difference is not only inconsistent and therefore impractical in itself. It ripples on and breaks the AAS4J serializers.

Therefore, I suggest to adjust the naming to DataSpecificationIec61360 in RDF and SHACL as well.
@mjacoby
Copy link

mjacoby commented Apr 13, 2023

This also affects the following elements

  • DataTypeIEC61360
  • LangStringDefinitionTypeIEC61360
  • LangStringPreferredNameTypeIEC61360
  • LangStringShortNameTypeIEC61360

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Apr 13, 2023 •
edited
Loading

Yes, this seems to be inconsistent and should be fixed. @sebbader-sap @s-heppner : we then also need a new release

This was referenced Apr 13, 2023
Closed
Merged
@sebbader-sap
Copy link
Contributor

Correct, will take a look together with @s-heppner

mristin added a commit to aas-core-works/aas-core-codegen that referenced this issue Apr 18, 2023
@mristin
[V3] Change naming in RDF & SHACL
0be1182 
We change naming in V3 for RDF & SHACL to be consistent with XSD, and
also to make life easier for downstream clients.

See: admin-shell-io/aas-specs#263
@mristin mristin mentioned this issue Apr 18, 2023
Merged
mristin added a commit to aas-core-works/aas-core-codegen that referenced this issue Apr 18, 2023
@mristin
[V3] Change naming in RDF & SHACL (#380)
2587a3f 
We change naming in V3 for RDF & SHACL to be consistent with XSD, and
also to make life easier for downstream clients.

See: admin-shell-io/aas-specs#263
mristin added a commit to aas-core-works/aas-core3.0-testgen that referenced this issue Apr 18, 2023
@mristin
Update to new naming for RDF & SHACL
8b7d56f 
We changed the naming in aas-core-codegen to be consistent with XML, and
also to make the life easier for the downstream clients.

See: admin-shell-io/aas-specs#263

We update the development requirements to and re-generate everything
with [aas-core-codegen 2587a3f].

[aas-core-codegen 2587a3f]: aas-core-works/aas-core-codegen@2587a3f
@mristin mristin mentioned this issue Apr 18, 2023
Merged
mristin added a commit to aas-core-works/aas-core3.0-testgen that referenced this issue Apr 18, 2023
@mristin
Update to new naming for RDF & SHACL (#10)
80ca1cd 
We changed the naming in aas-core-codegen to be consistent with XML, and
also to make the life easier for the downstream clients.

See: admin-shell-io/aas-specs#263

We update the development requirements to and re-generate everything
with [aas-core-codegen 2587a3f].

[aas-core-codegen 2587a3f]: aas-core-works/aas-core-codegen@2587a3f
s-heppner added a commit that referenced this issue Apr 19, 2023
@s-heppner
Update the naming scheme of RDF and SHACL
8678866 
Prior, the naming scheme of the RDF and
SHACL schemata were inconsistent to the
JSON and XML schemat in their naming
of abbreviations.

This fixes it by applying the same
naming rules on the RDF and SHACL
schemata.
Furthermore we update the examples.

This fixes #263
@s-heppner s-heppner mentioned this issue Apr 19, 2023
Merged
@arnoweiss arnoweiss mentioned this issue Apr 19, 2023
Closed
2 tasks
sebbader-sap added a commit that referenced this issue Apr 26, 2023
@sebbader-sap
Prepare Bugfix Release 3.0.7 (#275)
21e6850 
* Update the naming scheme of RDF and SHACL
* schemas/rdf: Remove `work-in-progress`-flag from `owl:versionInfo`
* Update the generated XML examples
* `schemas/xml`: Add missing `environment` element
* Add information for the 3.0.7 release

Fixes #260, #261, and #263
@arnoweiss
Copy link
Author

Solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the naming scheme of RDF and SHACL admin-shell-io/aas-specs
4 participants
@mjacoby @BirgitBoss @arnoweiss @sebbader-sap