Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Fix csproj's to build locally #15

Merged
merged 1 commit into from
May 18, 2020

Conversation

mristin
Copy link
Collaborator

@mristin mristin commented May 16, 2020

The solution could not build on a fresh Azure virtual desktop. It turns
out that there were a couple of missing includes in the csproj's that
needed fixing which were not apparent when building from the Visual
Studio.

The solution could not build on a fresh Azure virtual desktop. It turns
out that there were a couple of missing includes in the csproj's that
needed fixing which were not apparent when building from the Visual
Studio.
@mristin mristin force-pushed the mristin/Fix-csprojs-to-build-locally branch from baf77db to 768a144 Compare May 16, 2020 19:09
@mristin mristin requested a review from aorzelskiGH May 16, 2020 19:09
@mristin
Copy link
Collaborator Author

mristin commented May 16, 2020

@aorzelskiGH Here is the very first pull request for you to review :-) We can have a look at it together on Monday.

@mristin
Copy link
Collaborator Author

mristin commented May 17, 2020

(The checks are failing since Github action build is not yet in place, coming in a separate pull request.)

Copy link
Contributor

@aorzelskiGH aorzelskiGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code :-) LGTM.

@mristin mristin merged commit c6fc0c7 into V20DataModel May 18, 2020
mristin added a commit that referenced this pull request Jul 11, 2020
The solution could not build on a fresh Azure virtual desktop. It turns
out that there were a couple of missing includes in the csproj's that
needed fixing which were not apparent when building from the Visual
Studio.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants