Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

Upgraded to SonarQube 7.9 #46

Closed
wants to merge 3 commits into from
Closed

Conversation

kkaarrss
Copy link

@kkaarrss
Copy link
Author

sonar-build-breaker-plugin-2.3-SNAPSHOT.zip
And the jar. Tested locally with SonarQube 7.9.

@frankyjquintero
Copy link

The plugin works perfectly with version 7.9 of sonar and teamcity 2019.1.2

@sandro-h
Copy link
Collaborator

sandro-h commented Nov 15, 2019

Hey @kkaarrss, thanks for your work! As you mentioned yourself in #44, some of it doesn't fit so well with Sonarqube 7.9:

  • The Issue Severity Breaker doesn't make sense anymore, because preview analysis was dropped in 7.7. The AnalysisMode class for example is deprecated, and most likely the severity breaker code has no effect at all since shouldExecuteOnProject never evaluates to true (did not test it either).
  • According to the Sonarqube 7.9 Supported Platform requirements, we shouldn't use JDK 9 just yet (or at least we should target Java 8), because the plugin is used during analysis.

Right now I'm leaning towards using the changes from https://github.com/adnovum/sonar-build-breaker/commits, which are more minimalistic. I still need to verify that against Sonarqube 7.9 though (it targets 7.7.). From there we can extend and update the codebase and dependencies as necessary.
Full disclosure: that fork was done by a colleague at my employer. If you disagree with this course and think there are valuable improvements here we should take up, do let me know.

@sandro-h
Copy link
Collaborator

We now released a 2.3.0 version that's compatible with SonarQube 7.9. Thanks again for your work.

@sandro-h sandro-h closed this Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants