Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

Use sonar.scanner.metadataFilePath if set #47

Closed

Conversation

adriaanthomas
Copy link

Builds on #46.

Since SonarQube 7.2 this property exists to change the path of report-task.txt. Before this change, this file would always be read from the default directory, resulting in an IllegalStateException if sonar.scanner.metadataFilePath points to some other directory.

We ran into this since this commit in the Azure Pipelines Sonar extension, which fixed this issue.

kkaarrss and others added 4 commits July 18, 2019 20:53
Mockito and Java 9 don't like eachother much...
This is a new SonarQube 7.2 property, which is not used by the build breaker, which always used the default directory.
@sandro-h
Copy link
Collaborator

sandro-h commented Nov 22, 2019

Hey @adriaanthomas, thanks for your contribution. It makes sense indeed to honor that property in the build breaker. We recently took over the maintainership of this plugin and had to process the backlog of issues, especially regarding compatibility with SonarQube 7.x. This is done now, but as a result quite a lot of the code base has been adapted and your PR would modify far too much.
If you're still interested in helping get that fix into the code base, you'll need to rebase your branch and probably deal with some conflicts. I'm hoping your actual change is small enough to easily apply again.

@sandro-h
Copy link
Collaborator

Thanks again for the contribution. Closing this in favor of #59

@sandro-h sandro-h closed this Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants