Fix for issue #4 Flashing and jumping menus in Firefox

DOMAttrModified event handler, which was added to provide support for the way Windows 8 Narrator expands and collapses elements using the aria-expanded attribute, wasn't getting removed properly.
adobe-accessibility · Oct 10, 2013 · 0b4fdd7 · 0b4fdd7
1 parent 71bfe6f
commit 0b4fdd7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/js/jquery-accessibleMegaMenu.js b/js/jquery-accessibleMegaMenu.js
@@ -224,8 +224,7 @@ limitations under the License.
 
             _toggleExpandedEventHandlers.call(this, hide);
             $('html').off('mouseup.outside-accessible-megamenu, touchend.outside-accessible-megamenu, mspointerup.outside-accessible-megamenu, pointerup.outside-accessible-megamenu', _clickOutsideHandler);
-
-            menu.find('.' + settings.panelClass).off('DOMAttrModified.accessible-megamenu', _DOMAttrModifiedHandler);
+            menu.find('[aria-expanded].' + this.settings.panelClass).off('DOMAttrModified.accessible-megamenu');
 
             if (hide) {
                 topli = menu.find('.' + settings.topNavItemClass + ' .' + settings.openClass + ':first').closest('.' + settings.topNavItemClass);
@@ -241,6 +240,7 @@ limitations under the License.
                     if ((event.type === 'keydown' && event.keyCode === Keyboard.ESCAPE) || event.type === 'DOMAttrModified') {
                         newfocus = topli.find(':tabbable:first');
                         setTimeout(function () {
+                            menu.find('[aria-expanded].' + that.settings.panelClass).off('DOMAttrModified.accessible-megamenu');
                             newfocus.focus();
                             that.justFocused = false;
                         }, 99);
@@ -660,7 +660,7 @@ limitations under the License.
             if (hide) {
                 $('html').off('mouseup.outside-accessible-megamenu, touchend.outside-accessible-megamenu, mspointerup.outside-accessible-megamenu,  pointerup.outside-accessible-megamenu', _clickOutsideHandler);
 
-                menu.find('.' + this.settings.panelClass).on('DOMAttrModified.accessible-megamenu', _DOMAttrModifiedHandler.bind(this));
+                menu.find('[aria-expanded].' + this.settings.panelClass).off('DOMAttrModified.accessible-megamenu', _DOMAttrModifiedHandler);
             } else {
                 $('html').on('mouseup.outside-accessible-megamenu, touchend.outside-accessible-megamenu, mspointerup.outside-accessible-megamenu,  pointerup.outside-accessible-megamenu', _clickOutsideHandler.bind(this));