-
Notifications
You must be signed in to change notification settings - Fork 198
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add openOnMouseover setting, and toggleButtonClass for responsive layout
To normalize behavior of top navigation links on desktop and mobile, the default behavior will be for the menu to remain closed on hover. Click should toggle the menu regardless of whether the link has a valid `href`. With `openOnMouseover: true`, hover will open the menu as before and with the menu open, clicking a top-level navigation item with a valid `href` should open the url. Add toggleButtonClass to specify a button that should toggle the menu in a responsive layout on mobile devices. Incorporate media queries for responsive layout breakpoints.
- Loading branch information
1 parent
84b7461
commit d445afc
Showing
4 changed files
with
480 additions
and
150 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
d445afc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When openOnMouseover is set to true, with the menu open, pressing Enter or Space on a top-level navigation item with a valid
href
does not open the url.Also, when openOnMouseover is set to true, with the menu open, tapping (on a touch enabled device) on a top-level navigation item with a valid
href
does not open the url.