Bump third party dependencies #12
Conversation
| @@ -215,7 +215,7 @@ | |||
| return Q.nfcall(tmp.dir, {unsafeCleanup : true}); | |||
| } | |||
| }) | |||
| .then(function (workingDir) { | |||
| .spread(function (workingDir) { | |||
There was a problem hiding this comment.
The errbacks for tmp.dir and tmp.file now have more parameters. It should have always been spread, but since it used to only have one non-error parameter, it worked fine.
See raszi/node-tmp#25 and raszi/node-tmp#27 (and, if you're bored, raszi/node-tmp#26)
There was a problem hiding this comment.
But the first control path returns a string. Does spread work with non-array values?
There was a problem hiding this comment.
Oops. Good catch. No, spread doesn't work that way. Will fix.
There was a problem hiding this comment.
Fixed in e2a0e5c
| @@ -212,7 +212,10 @@ | |||
| return workingDir; | |||
| })); | |||
| } else { | |||
| return Q.nfcall(tmp.dir, {unsafeCleanup : true}); | |||
| return (Q.nfcall(tmp.dir, {unsafeCleanup : true}) | |||
There was a problem hiding this comment.
I bet you could also just do return (Q.nfcall(tmp.dir, {unsafeCleanup : true}).get(0) but lol whatever thxbye
|
Good times. Great patch. |
Bump third party dependencies
No description provided.