This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
Search: placing libraries graphic results in error #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -68,7 +68,7 @@ | |||
| "webpack-notifier": "^1.2.1" | |||
| }, | |||
| "dependencies": { | |||
| "bluebird": "^3.0.5", | |||
| "bluebird": "^3.1.1", | |||
There was a problem hiding this comment.
This shouldn't be here (or if you really wanna update bluebird, you also need to update shrinkwrap, but I prefer you do it separately)
There was a problem hiding this comment.
Nvm, I should read the full description.
baaygun
pushed a commit
that referenced
this pull request
Jan 15, 2016
Search: placing libraries graphic results in error
|
wow, that was quick! thanks for merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: search for libraries graphic and hit return to place any graphic will result in error.
I fixed this earlier but got distracted by a bluebird@3.0.6 bug (petkaantonov/bluebird#841) which will silent unhandled errors and exceptions (error is not shown in the console). Now it has been fixed in 3.1.0 and I saw we are already using 3.1.1 in
npm-shrinkwrap.json, so the problem no longer exists.