Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to work as a web server #120

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

Spaskich
Copy link
Contributor

Overview

This PR updates the Dockerfile to fix the following issues:

  • the build process gets stuck at the 'Configuring tzdata' asking for geographic area
  • at the 'Cloning into dynet' phase the build throws a 404 error because the eigen repository is no longer hosted on Bitbucket
  • the Flask and ps4 packages are missing

Notes

The whole process on updating the Dockefile can be seen here - #119
Huge thanks to @tiberiu44 for his help!

Testing Instructions

@Spaskich Spaskich closed this Dec 15, 2020
@Spaskich Spaskich reopened this Dec 15, 2020
@tiberiu44
Copy link
Contributor

The build fails because of incompatible DyNet version. We will fix this, once we switch to the 2.0 branch. The pull request looks good to me.

@tiberiu44 tiberiu44 merged commit a16373a into adobe:master Dec 15, 2020
@tiberiu44
Copy link
Contributor

Thanks again for the contribution!

Cheers,
Tibi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants