Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Integration #2

Closed
auniverseaway opened this issue Feb 3, 2020 · 6 comments
Closed

CI Integration #2

auniverseaway opened this issue Feb 3, 2020 · 6 comments

Comments

@auniverseaway
Copy link
Member

Expected Behaviour

As a developer, I would like a CI service to build my branch for which my PR is based on so that it can check for:

  1. Unit test coverage (Java & Javascript)
  2. Security vulnerabilities (as described by Cloud Manager rules)
  3. Ability to compile

Actual Behaviour

There is no CI service.

Reproduce Scenario (including but not limited to)

  1. Submit a PR

Steps to Reproduce

  1. Submit a PR

Platform and Version

All

Sample Code that illustrates the problem

None

Logs taken while reproducing problem

Submitted PR

@npeltier
Copy link
Contributor

npeltier commented Feb 5, 2020

@auniverseaway should we give a try to github actions?

@auniverseaway
Copy link
Member Author

I think so.

npeltier added a commit to npeltier/adobe-dx that referenced this issue Feb 14, 2020
- workflow file was missing license (adobe#2)
- also updated license header file
This was referenced Feb 14, 2020
@npeltier npeltier self-assigned this Feb 14, 2020
@npeltier
Copy link
Contributor

@auniverseaway pls have a look at https://github.com/adobe/adobe-dx/runs/446514339 a build is triggered for any push or pull request.
Will resume my work on this by adding unit test & codecov action in the workflow which should close this issue.

@npeltier npeltier added this to the SUMMIT 2020 milestone Mar 4, 2020
@ccongerp ccongerp moved this from To do to In progress in Flex MVP / Automated releases Mar 5, 2020
npeltier added a commit that referenced this issue Mar 6, 2020
npeltier added a commit that referenced this issue Mar 6, 2020
npeltier added a commit to npeltier/adobe-dx that referenced this issue Mar 6, 2020
npeltier added a commit that referenced this issue Mar 6, 2020
npeltier added a commit to npeltier/adobe-dx that referenced this issue Mar 6, 2020
npeltier added a commit that referenced this issue Mar 6, 2020
@npeltier
Copy link
Contributor

npeltier commented Mar 6, 2020

@auniverseaway i think we might run into some issues having exactly the same coverage as cloud manager, as i don't see an easy "free" way to integrate (all custom rules cloud manager runs) [https://docs.adobe.com/content/help/en/experience-manager-cloud-manager/using/how-to-use/understand-your-test-results.html]. May be running with default + some rules (basically findbugs ones could be added) is ok for now?

npeltier added a commit that referenced this issue Mar 6, 2020
@npeltier
Copy link
Contributor

npeltier commented Mar 9, 2020

@auniverseaway problem found with github actions is PR can't access repo's secrets. Hence you can't have nice sonarcloud reports for each PR made (just once commit gets actually in the repo's branch) (see #16)

@npeltier npeltier moved this from In progress to Done in Flex MVP / Automated releases Mar 23, 2020
@npeltier
Copy link
Contributor

let's call it done for now, i'm sure it will evolve but we have all we needed in the initial description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants