-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Integration #2
Comments
@auniverseaway should we give a try to github actions? |
I think so. |
- workflow file was missing license (adobe#2) - also updated license header file
@auniverseaway pls have a look at https://github.com/adobe/adobe-dx/runs/446514339 a build is triggered for any push or pull request. |
@auniverseaway i think we might run into some issues having exactly the same coverage as cloud manager, as i don't see an easy "free" way to integrate (all custom rules cloud manager runs) [https://docs.adobe.com/content/help/en/experience-manager-cloud-manager/using/how-to-use/understand-your-test-results.html]. May be running with default + some rules (basically findbugs ones could be added) is ok for now? |
@auniverseaway problem found with github actions is PR can't access repo's secrets. Hence you can't have nice sonarcloud reports for each PR made (just once commit gets actually in the repo's branch) (see #16) |
let's call it done for now, i'm sure it will evolve but we have all we needed in the initial description |
Expected Behaviour
As a developer, I would like a CI service to build my branch for which my PR is based on so that it can check for:
Actual Behaviour
There is no CI service.
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version
All
Sample Code that illustrates the problem
None
Logs taken while reproducing problem
Submitted PR
The text was updated successfully, but these errors were encountered: