Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unhandled Promise Rejection in lib-franklin fetchPlaceholders #204

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: Unhandled Promise Rejection in lib-franklin fetchPlaceholders #204

merged 2 commits into from
Apr 20, 2023

Conversation

karlpauls
Copy link
Contributor

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Apr 6, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@trieloff trieloff requested a review from rofe April 18, 2023 09:21
@nc-andreashaller nc-andreashaller mentioned this pull request Apr 20, 2023
Open
rofe
rofe reviewed Apr 20, 2023
View reviewed changes
scripts/lib-franklin.js Outdated Show resolved Hide resolved
@aem-code-sync
Copy link

aem-code-sync bot commented Apr 20, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@trieloff trieloff merged commit c67996a into adobe:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rofe rofe rofe approved these changes

@trieloff trieloff trieloff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled Promise Rejection in lib-franklin fetchPlaceholders
3 participants
@karlpauls @trieloff @rofe