Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2262: use Adobe AEM SEO api for product and category pages #723

Merged
merged 9 commits into from Oct 28, 2021

Conversation

Buuhuu
Copy link
Contributor

@Buuhuu Buuhuu commented Oct 21, 2021

Description

This PR implements canonical link handling by using the mechanisms already in place for product and category sitemaps. Furthermore it implements the alternate language links for product/category pages in order to prevent the WCM Core Components Page behaviour to be in place.

This PR also annotates the model interface in ...models.page, ...models.product and ...model.productlist as ConsumerType.

Related Issue

CIF-2262, CIF-2102
adobe/aem-core-wcm-components#1647

Motivation and Context

Feature compatibility with the WCM Core Components

How Has This Been Tested?

Locally and unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@Buuhuu Buuhuu added the enhancement New feature or request label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #723 (7bd8c9e) into master (159ea27) will decrease coverage by 0.01%.
The diff coverage is 79.24%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #723      +/-   ##
============================================
- Coverage     88.76%   88.74%   -0.02%     
- Complexity     1707     1718      +11     
============================================
  Files           294      295       +1     
  Lines          7467     7511      +44     
  Branches       1096     1102       +6     
============================================
+ Hits           6628     6666      +38     
- Misses          625      626       +1     
- Partials        214      219       +5     
Flag Coverage Δ
integration 58.65% <60.37%> (+0.37%) ⬆️
jest 86.32% <ø> (ø)
karma 89.86% <ø> (ø)
unittests 88.65% <71.69%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/internal/models/v1/page/PageMetadataImpl.java 81.25% <0.00%> (-5.42%) ⬇️
...vices/sitemap/SitemapLinkExternalizerProvider.java 100.00% <ø> (+12.00%) ⬆️
...erce/core/components/models/page/PageMetadata.java 0.00% <0.00%> (ø)
...mmerce/core/components/models/product/Product.java 100.00% <ø> (ø)
...ore/components/models/productlist/ProductList.java 100.00% <ø> (ø)
...nternal/models/v1/productlist/ProductListImpl.java 90.52% <81.81%> (-1.79%) ⬇️
...onents/internal/models/v1/product/ProductImpl.java 88.43% <82.60%> (-0.53%) ⬇️
...e/components/internal/models/v1/page/PageImpl.java 85.71% <83.33%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 159ea27...7bd8c9e. Read the comment docs.

@LSantha LSantha merged commit 3e3915c into master Oct 28, 2021
@LSantha LSantha deleted the issue/CIF-2262 branch October 28, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants