New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2262: use Adobe AEM SEO api for product and category pages #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buuhuu
requested review from
mhaack,
herzog31,
LSantha and
laurentiumagureanu
October 21, 2021 19:05
Codecov Report
@@ Coverage Diff @@
## master #723 +/- ##
============================================
- Coverage 88.76% 88.74% -0.02%
- Complexity 1707 1718 +11
============================================
Files 294 295 +1
Lines 7467 7511 +44
Branches 1096 1102 +6
============================================
+ Hits 6628 6666 +38
- Misses 625 626 +1
- Partials 214 219 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
herzog31
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements canonical link handling by using the mechanisms already in place for product and category sitemaps. Furthermore it implements the alternate language links for product/category pages in order to prevent the WCM Core Components Page behaviour to be in place.
This PR also annotates the model interface in
...models.page
,...models.product
and...model.productlist
asConsumerType
.Related Issue
CIF-2262, CIF-2102
adobe/aem-core-wcm-components#1647
Motivation and Context
Feature compatibility with the WCM Core Components
How Has This Been Tested?
Locally and unit tests
Screenshots (if appropriate):
Types of changes
Checklist: