CIF-2842 - Extend List component to list pages by product or category #946
Conversation
* using Associated Content Service in commere content fragment and commerce experience fragment component
* initial implementation of commerce list component * added unit tets * updated examples and documentation
* add component link in readme
|
The tests will pass after CIF add-on release. |
LSantha
requested review from
herzog31,
vladbailescu,
laurentiumagureanu and
Buuhuu
| } | ||
| } | ||
|
|
||
| if (contentQuery == null) { |
There was a problem hiding this comment.
Iiuc this causes the component to not support any of the WCM List's behaviours right? Shouldn't we implement a fallback here? Otherwise customers would end up with two list components, one for the wcm case and one for the cif case.
Ideally we could just create the super type model without providing any additional parameters in this case. This would make the Commerce List component a drop in replacement for the wcm list.
There was a problem hiding this comment.
Actually the wcmList is already initialized via injection, so nothing to do there.
My intention is to provide a drop in replacement for WCM List.
* use aem-cif-sdk-api dependency
* replaced injection based initialization of wcmList with factory based initialization
* replaced injection based initialization of wcmList with factory based initialization
* removed unneeded assertions from unit test
* fixed teaserDelegate
* updated aem-cif-sdk-api dependency
* fixing IT failures
* fixing IT failures
* install the add-on for classic too
* install the add-on for classic too
* added IT for commerce list * adjusted Navigation ITs * enabled ContentFragmentComponentIT for AEM 6.5 which was forgotten in disabled state
Codecov Report
@@ Coverage Diff @@
## master #946 +/- ##
============================================
+ Coverage 89.45% 89.47% +0.02%
- Complexity 2182 2204 +22
============================================
Files 350 351 +1
Lines 9803 9860 +57
Branches 1410 1422 +12
============================================
+ Hits 8769 8822 +53
- Misses 739 742 +3
- Partials 295 296 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Related Issue
CIF-2842
How Has This Been Tested?
Unit test, UI test, IT, manually.
Screenshots (if appropriate):
Types of changes
Checklist: