FORMS-12557 Forms run enhancements #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
rum
branch
from
c6913b0
to
8a012a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1033 +/- ##
=========================================
Coverage 80.40% 80.40%
Complexity 738 738
=========================================
Files 91 91
Lines 2057 2057
Branches 273 273
=========================================
Hits 1654 1654
Misses 251 251
Partials 152 152 ☔ View full report in Codecov by Sentry. |
rismehta
commented
Jan 18, 2024
| @@ -445,7 +448,7 @@ class FormFieldBase extends FormField { | |||
| if (this.errorDiv) { | |||
| this.errorDiv.innerHTML = state.validationMessage; | |||
| if (state.validity.valid === false) { | |||
| this.#triggerEventOnGuideBridge(this.ELEMENT_ERROR_SHOWN); | |||
| this.#triggerEventOnGuideBridge(this.ELEMENT_ERROR_SHOWN, {'validationMessage' : state.validationMessage}); | |||
There was a problem hiding this comment.
validationMessage could have PII data, hence we would instead send the validationType in the beacon.
github-actions
bot
force-pushed
the
rum
branch
from
f724ab4
to
6c05d10
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
* FORMS-12557 Forms run enhancements * adding qualified name in data layer to support repeatibility * Fixing test * Adding validation type and fixing submit start * Adding rum JS library
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* FORMS-12557 Forms run enhancements * adding qualified name in data layer to support repeatibility * Fixing test * Adding validation type and fixing submit start * Adding rum JS library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: