-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FORMS-13810: Add the field to allow custom message for format in date… #1158
Conversation
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1158 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 773 773
=========================================
Files 91 91
Lines 2110 2110
Branches 285 285
=========================================
Hits 1704 1704
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write a runtime test case for this as part of datapicker spec so that the use-case works end to end
ce3814e
to
3dda7bf
Compare
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
ui.tests/test-module/specs/datepicker/datepicker.runtime.spec.js
Outdated
Show resolved
Hide resolved
...n/content/jcr_root/content/forms/af/core-components-it/samples/datepicker/basic/.content.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment on collateral
6e7378d
to
2bfeaf1
Compare
Accessibility Violations Found
|
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
#1158) * FORMS-13810: Add the field to allow custom message for format in date picker * FORMS-13810: Test case added * FORMS-13810: Review comments incorporated.
#1158) * FORMS-13810: Add the field to allow custom message for format in date picker * FORMS-13810: Test case added * FORMS-13810: Review comments incorporated.
… picker
Description
Related Issue
FORMS-13810
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
When no custom message provided
Added a field to add custom message for format
After custom message is added
Types of changes
Checklist: