fixed issue for Persian language #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Apr 4, 2024
| @@ -729,13 +729,18 @@ if (typeof window.DatePickerWidget === 'undefined') { | |||
| } | |||
|
|
|||
| #getLocalizedYear(date) { | |||
| if(this.#lang === 'th') { | |||
There was a problem hiding this comment.
Why do you need a language specific check in the widget ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1162 +/- ##
=========================================
Coverage 80.75% 80.75%
Complexity 773 773
=========================================
Files 91 91
Lines 2110 2110
Branches 285 285
=========================================
Hits 1704 1704
Misses 252 252
Partials 154 154 ☔ View full report in Codecov by Sentry. |
| @@ -729,13 +729,18 @@ if (typeof window.DatePickerWidget === 'undefined') { | |||
| } | |||
|
|
|||
| #getLocalizedYear(date) { | |||
| if(this.#lang === 'th') { | |||
There was a problem hiding this comment.
@devgurjar Add a comment saying that since thai locale has a different year, we need to do following
devgurjar
force-pushed
the
datepickerwidget
branch
from
39cb811
to
f18e03c
Compare
github-actions
bot
force-pushed
the
datepickerwidget
branch
from
f18e03c
to
1285fab
Compare
devgurjar
force-pushed
the
datepickerwidget
branch
from
1285fab
to
275bac7
Compare
github-actions
bot
force-pushed
the
datepickerwidget
branch
from
275bac7
to
aba758d
Compare
sakshi-arora1
approved these changes
Apr 4, 2024
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2024
Co-authored-by: dgurjar <dgurjar@adobe.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 7, 2024
Co-authored-by: dgurjar <dgurjar@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: